Todos los informes
Informes de Sunrise Sunset
#141680: "incorrect score display"
fixed: El error ha sido arreglado
2
¿Sobre qué es este informe?
¿Qué ha pasado? Por favor, selecciona una de las opciones siguientes
Error de visualización: cierta información del juego se mostraba erróneamente (sin repercusiones importantes en el juego)
Descripción detallada
• Por favor, describe el problema de visualización. Si tienes una captura de este error (buena práctica), puedes usar Imgur.com para subirla y copiar/pegar el enlace aquí.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect• ¿Qué navegador estás usando?
opera
Historial de informes
11 oct 2024 23:15 • Biolog Psihopat • Los desarrolladores aún no han podido reproducir el error:
12 oct 2024 2:21 • Biolog Psihopat • Los desarrolladores aún no han podido reproducir el error:
PS. that not at the end of the game, so this is a slightly different situation compared to my next note (that image from 2nd round, when game ends at 5th round)
20 oct 2024 12:35 • giantroach • El error ha sido confirmado por los desarrolladores:
- Isis power should be 4 instead of 6, and Apofis power should be 6 instead of 4.
- From the location cards image, it looks like happens in night phase.
- The left lane location number is set to `2` even though there isn't any card that modifies the number (it should be 1 in that case).
- The center lane location number is set to `3` even though `Maat` is presented (it should be 5 in that case).
Possibly there are two issues.
1. Plotting number is wrongly done in some case?
2. Day / Night state is wrongly set in some case? (while restoring game?)
- From the location cards image, it looks like happens in night phase.
- The left lane location number is set to `2` even though there isn't any card that modifies the number (it should be 1 in that case).
- The center lane location number is set to `3` even though `Maat` is presented (it should be 5 in that case).
Possibly there are two issues.
1. Plotting number is wrongly done in some case?
2. Day / Night state is wrongly set in some case? (while restoring game?)
26 oct 2024 15:32 • giantroach • El error ha sido confirmado por los desarrolladores:
I reproduced this bug myself.
1. This happened in 2nd round.
2. After browser refresh, it displayed correct result (this means the game state is restored correctly).
3. Replay from previous round did not reproduced the bug.
4. Wrongly displayed result was different from previous round result. i.e. This is not a bug that displays previous round result.
This needs further investigation.
1. This happened in 2nd round.
2. After browser refresh, it displayed correct result (this means the game state is restored correctly).
3. Replay from previous round did not reproduced the bug.
4. Wrongly displayed result was different from previous round result. i.e. This is not a bug that displays previous round result.
This needs further investigation.
26 oct 2024 16:22 • giantroach • El error ha sido confirmado por los desarrolladores:
One possible root cause is found:
github.com/giantroach/sunrisesunset/blob/v0.4/bga_src/backend/sunrisesunset.game.php#L1092
1. `'i18n' => ['lane'],` makes `lane` arg to be translated.
en.doc.boardgamearena.com/Translations
2. This `lane` arg is referred in client side code. And that expects one of `left`, `right` or `center`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L304
If a player is playing in other than English language (in my case Japanese), this logic won't work.
Though, it is weird that it displayed win / lose / tie on screen in this case.
1. scoreData.result is reset every `newRound`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L50
2. Displaying result logic explicitly checking the scoreData.result value without fallback.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/state.ts#L825-L841
So I suspect this is not yet everything.
github.com/giantroach/sunrisesunset/blob/v0.4/bga_src/backend/sunrisesunset.game.php#L1092
1. `'i18n' => ['lane'],` makes `lane` arg to be translated.
en.doc.boardgamearena.com/Translations
2. This `lane` arg is referred in client side code. And that expects one of `left`, `right` or `center`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L304
If a player is playing in other than English language (in my case Japanese), this logic won't work.
Though, it is weird that it displayed win / lose / tie on screen in this case.
1. scoreData.result is reset every `newRound`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L50
2. Displaying result logic explicitly checking the scoreData.result value without fallback.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/state.ts#L825-L841
So I suspect this is not yet everything.
6 nov 2024 20:00 • giantroach • El error ha sido confirmado por los desarrolladores:
Not everything, but nearly all the doubt is solved (Fixing needs an extra work.)
1. As I mentioned above, lane translation is one of the cause of this issue. Due to this bug, win / lose / draw is usually not be displayed when you are playing the game with other than English language.
2. When you restore the game state, score data from previous round will be restored. Current game logic is expecting to have those score data to be emptied every new round. So this is an unexpected state.
3. When score data isn't empty and when game state goes endRound, it immediately proceeds to display the game result, without waiting any other process.
4. Changing of state does not have any delay, unlike the notification handler that has max 1sec of intentional delay (to let player observe what is happening), so this causes displaying prev round score data mixed with current round data!
1. and 2. should be fixed. Do not restore the score data unless it is endRound state.
1. As I mentioned above, lane translation is one of the cause of this issue. Due to this bug, win / lose / draw is usually not be displayed when you are playing the game with other than English language.
2. When you restore the game state, score data from previous round will be restored. Current game logic is expecting to have those score data to be emptied every new round. So this is an unexpected state.
3. When score data isn't empty and when game state goes endRound, it immediately proceeds to display the game result, without waiting any other process.
4. Changing of state does not have any delay, unlike the notification handler that has max 1sec of intentional delay (to let player observe what is happening), so this causes displaying prev round score data mixed with current round data!
1. and 2. should be fixed. Do not restore the score data unless it is endRound state.
8 nov 2024 16:49 • giantroach • El error ha sido arreglado:
This bug is fixed.
Translation of lane name is partly disabled due to this fix and currently it is inconsistent.
This translation issue will be dealt separately.
Translation of lane name is partly disabled due to this fix and currently it is inconsistent.
This translation issue will be dealt separately.
Agregar a este informe
Por favor agrega aquí cualquier cosa que sea relevante para reproducir este error o entender tu sugerencia:
- Otro ID de partida / ID de jugada
- ¿Se resolvió el problema al pulsar F5?
- ¿Apareció el problema varias veces? ¿Cada vez? ¿Aleatoriamente?
- Si tienes una captura de este error (buena práctica), puedes usar Imgur.com para subirla y copiar/pegar el enlace aquí.
